aposd-reviewing-module-design

The aposd-reviewing-module-design skill provides a rigorous, checklist-driven framework for evaluating software architecture during code reviews, PR processes, and design discussions. Rooted in John Ousterhout's 'A Philosophy of Software Design,' this skill helps identify 'shallow' modules, information leakage, and structural complexity that lead to long-term technical debt. It forces the agent to look beyond surface-level syntax and perform deep structural analysis on interface design, cognitive load, and layer abstractions.

• Performs a multi-phase structural evaluation: Complexity Symptoms, Module Depth, Information Hiding, Layer Abstraction, and Together/Apart analysis.

• Utilizes specific red-flag detection such as Pass-Through Methods, Temporal Decomposition, and Classitis to pinpoint problematic architectural patterns.

• Provides a systematic 'Steel-man' validation step to ensure design choices are not dismissed before confirming their intent.

• Generates structured reporting output including Critical Issues, Moderate Issues, Observations, and Positive Patterns for actionable feedback.

• Follows strict decision procedures for refactoring, such as the Depth vs. Length rule and Together/Apart decision matrices.

• Designed for senior engineers, architects, and automated code review agents.

• Triggers on PR reviews, architectural assessments, and module complexity analysis.

• Requires critical thinking regarding unknown unknowns and leaky abstractions.

• Can be used in tandem with other engineering skills to enforce pre-gate and post-gate standards in automated build pipelines.

• Inputs include source code, module interfaces, and pull request diffs; outputs are professional design review reports.